Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve get toggleItems code #6569

Merged
merged 1 commit into from Apr 17, 2020
Merged

improve get toggleItems code #6569

merged 1 commit into from Apr 17, 2020

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Apr 17, 2020

Re: cocos-creator/2d-tasks#

Changes:

  • 优化 ToggleContainer 获取 toggleItems 代码
  • 回退之前修改 CCView convertToLocationInView 代码

image

toggles.push(toggle);
}
}
return toggles;
Copy link
Member

@jareguo jareguo Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.node.children.map(function (item) {
  return item.getComponent(cc.Toggle);
}).filter(Boolean);

revert convertToLocationInView code for (cocos#6536)
PPpro
PPpro approved these changes Apr 17, 2020
@PPpro PPpro merged commit 5072c74 into cocos:v2.4.0 Apr 17, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants