Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iOS 14 display issue #6974

Merged
merged 1 commit into from Jul 29, 2020
Merged

Conversation

holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Jul 10, 2020

Re: cocos/2d-tasks#2982

Changes:

  • fix iOS 14 display issue

@jareguo
Copy link
Member

jareguo commented Jul 11, 2020

据论坛反馈这个方法似乎在老版本上还是会有问题,等 iOS 14 正式版本再看看老版本吧,说不定苹果到时就修复了

@holycanvas holycanvas force-pushed the v2.4.2-release branch 2 times, most recently from b31e343 to d1239c2 Compare Jul 14, 2020
@zhanxiaoge
Copy link

zhanxiaoge commented Jul 15, 2020

建议把if (CC_EDITOR)改成 if (CC_DEV)

@holycanvas
Copy link
Contributor Author

holycanvas commented Jul 16, 2020

建议把if (CC_EDITOR)改成 if (CC_DEV)

不行吧,万一正好用 iOS 14 beta.2 的手机来预览,显示就有问题了

@zhanxiaoge
Copy link

zhanxiaoge commented Jul 16, 2020

建议把if (CC_EDITOR)改成 if (CC_DEV)

不行吧,万一正好用 iOS 14 beta.2 的手机来预览,显示就有问题了

哈哈,也有可能,交给官方决定了,我现在自己是使用CC_DEV,CC_EDITOR会让本地浏览器无法调试,还得再去改模版文件。

@holycanvas holycanvas force-pushed the v2.4.2-release branch 2 times, most recently from d96a665 to d1239c2 Compare Jul 20, 2020
@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

cocos2d-js上按此方法修复 报错 ReferenceError: Can't find variable: CC_EDITOR 帮忙看下

@holycanvas
Copy link
Contributor Author

holycanvas commented Jul 20, 2020

cocos2d-js上按此方法修复 报错 ReferenceError: Can't find variable: CC_EDITOR 帮忙看下

那就先不要 if (CC_EDITOR) 这个分支试试

@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

cocos2d-js上按此方法修复 报错 ReferenceError: Can't find variable: CC_EDITOR 帮忙看下

那就先不要 if (CC_EDITOR) 这个分支试试

先去掉 if (CC_EDITOR) {} 吗 直接 this.container = localContainer = localCanvas.parentNode;?

@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

麻烦大佬贴个代码看看

@holycanvas
Copy link
Contributor Author

holycanvas commented Jul 20, 2020

先去掉 if (CC_EDITOR) {} 吗 直接 this.container = localContainer = localCanvas.parentNode;?

@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

不行 还是白屏

@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

"TypeError: null is not an object (evaluating 'cc.container.parentNode')"

@lijiang3136146
Copy link

lijiang3136146 commented Jul 20, 2020

cocos2d 3.17版本 H5 线上很多游戏在跑着 帮忙看些 能否出一个修复方案

@holycanvas
Copy link
Contributor Author

holycanvas commented Jul 29, 2020

测试 iOS 14 beta3 还是存在此问题

@holycanvas
Copy link
Contributor Author

holycanvas commented Jul 29, 2020

先合并,如果后续有修复,可以再回退

@holycanvas holycanvas merged commit 07a4059 into cocos:v2.4.2-release Jul 29, 2020
1 check passed
@yue19870813
Copy link

yue19870813 commented Aug 3, 2020

目前这种解决方案还是存在问题,H5上画布会白屏闪一下,体验很不好,除了ios14以外也会变成这样。

@TimOfTheYear
Copy link

TimOfTheYear commented Aug 6, 2020

This issue appears to be resolved in iOS 14 Beta 4.

holycanvas added a commit to holycanvas/engine that referenced this pull request Aug 19, 2020
holycanvas added a commit that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants