Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set InputAssembler.length to 0 when there is no particle #7060

Conversation

caogtaa
Copy link

@caogtaa caogtaa commented Jul 31, 2020

Re: cocos-creator/2d-tasks#

Changes:

  • 粒子系统的粒子数为0时,设置InputAssembler的长度为0。

    如果不这么做,在下一次重新播放粒子系统的时候,由于IA里残留了老数据,第1帧渲染的粒子是老的(如果第1帧没有及时发射新粒子)

@caogtaa caogtaa changed the base branch from master to v2.4.2-release Aug 1, 2020
@cocos-robot cocos-robot changed the base branch from v2.4.2-release to v2.4.3-release Aug 3, 2020
Copy link
Contributor

@cocos-robot cocos-robot left a comment

We switched this PR to v2.4.3-release because v2.4.2-release is about to be deleted.

@holycanvas holycanvas requested a review from caryliu1999 Aug 3, 2020
@holycanvas
Copy link
Contributor

holycanvas commented Aug 4, 2020

感谢!

@holycanvas holycanvas changed the title 粒子系统的粒子数为0时,设置InputAssembler的长度为0 set InputAssembler.length to 0 when there is no particle Aug 4, 2020
@holycanvas holycanvas merged commit 97522fd into cocos:v2.4.3-release Aug 4, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants