Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix click video player callback use isPlaying when the pause invalid #7372

Merged
merged 2 commits into from Sep 16, 2020

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Sep 14, 2020

Re: cocos/2d-tasks#3129

Changes:

  • 修复如果在 click 视频回调的时候使用了 isPlaying 会导致 pause 无效 (我发现这个代码很魔幻,为什么我在获取播放状态的时候还要去 play 它,奇怪的知识有增加了)

@knoxHuang knoxHuang requested a review from PPpro Sep 14, 2020
PPpro
PPpro approved these changes Sep 14, 2020
@holycanvas holycanvas merged commit e047e5f into cocos:v2.4.3-release Sep 16, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants