Position Delete & Normal Compress: 3.4.1 #9939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -23748,9 +23748,16 @@
format: number;
location: number;
}[];
blocks: never[];
- samplerTextures: never[];
+ samplerTextures: {
+ name: string;
+ type: number;
+ count: number;
+ defines: never[];
+ stageFlags: number;
+ binding: number;
+ }[];
buffers: {
name: string;
memoryAccess: number;
defines: string[];
|
DolaMay
commented
Jan 7, 2022
jk20012001
reviewed
Jan 7, 2022
| // fixme: default value is 0, and give black result | ||
| float fogFactor; | ||
| CC_TRANSFER_FOG_BASE(vec4(position, 1), fogFactor); | ||
| CC_TRANSFER_FOG_BASE(vec4(s.position, 1), fogFactor); |
Contributor
There was a problem hiding this comment.
这里不要往s结构体里填position然后又取出来用，安卓浏览器上会精度全丢的， 直接用vec3 position=screen2WS(vec3(gl_FragCoord.xy, depth)).xyz; 后面统一用这个position
GengineJS
approved these changes
Jan 7, 2022
pandamicro
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/3d-tasks#
Changelog:
*