fixed downloader.onProgress call error #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuzhiming
approved these changes
Nov 2, 2019
看了上下文，感觉 downloadBytes 和 downloadNow 的命名有点不清楚，导致修改的时候参数顺序写错了，可以考虑把两个变量的命名修改一下
|
我暂时没想到其它更好的命名 |
|
这个之后再优化吧 |
zhefengzhang
added a commit
to zhefengzhang/cocos2d-x-lite
that referenced
this issue
Aug 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
RE: cocos/2d-tasks#2028 .
根据调试了代码调用上下文，len 的功能应该是 ：the number of bytes to write. 也就是要写入的字节数。
而 len 是 onProgress 需要接受的参数 downloadBytes。
len 也是 nativeOnProgress 需要的 dl
在 native 上测试正常。