Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix websocket crash on android 64 #2074

Merged
merged 1 commit into from Jan 16, 2020

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Jan 13, 2020

ASAN report error on android 64 devices

ASAN report error on android 64 devices
@holycanvas holycanvas requested a review from minggo Jan 13, 2020
@cocos-robot cocos-robot changed the base branch from v2.3.0 to v2.3.0-release Jan 13, 2020
Copy link
Contributor

@cocos-robot cocos-robot left a comment

@PatriceJiang, v2.3.0 branch will be deleted, so we edited the base branch to v2.3.0-release, or this PR will be killed by GitHub.
Please review the commits history to ensure that the PR does not polluted by unneeded commits from your origin branch.
If you need to merge to other branch, you can first click the Edit button on the right side of the PR title, then switch the base branch.
If necessary, welcome to resubmit a new PR. Thanks!

@minggo
Copy link
Contributor

@minggo minggo commented Jan 16, 2020

为什么在 64 位会是 ASAN?

@PatriceJiang
Copy link
Contributor Author

@PatriceJiang PatriceJiang commented Jan 16, 2020

测试只有64位Android机器执行才报错。 CP反馈的也是只有64位有问题。

@minggo
Copy link
Contributor

@minggo minggo commented Jan 16, 2020

那具体的原因清楚吗?

@PatriceJiang
Copy link
Contributor Author

@PatriceJiang PatriceJiang commented Jan 16, 2020

可能和android libc++的实现相关, 同样的代码在 iOS 上是正常的

minggo
minggo approved these changes Jan 16, 2020
@holycanvas holycanvas merged commit 14ecbc8 into cocos:v2.3.0-release Jan 16, 2020
1 check passed
@PatriceJiang PatriceJiang deleted the v2.3.0-asan-websocket branch Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants