Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix V8 chrome devtool url #2186

Merged

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Feb 26, 2020

@holycanvas holycanvas requested a review from minggo Feb 26, 2020
minggo
minggo approved these changes Feb 26, 2020
@holycanvas holycanvas merged commit d6919d2 into cocos:v2.3.1-release Feb 26, 2020
1 check passed
@@ -1042,7 +1042,7 @@ Change to:
#### Windows

* Compile, run the game (or run directly in the Creator simulator)
* Open with Chrome: [chrome-devtools://devtools/bundled/inspector.html?v8only=true&ws=127.0.0.1:6086/00010002-0003-4004-8005-000600070008](chrome-devtools://devtools/bundled/inspector.html?v8only=true&ws=127.0.0.1:6086/00010002-0003-4004-8005-000600070008)
* Open with Chrome: [chrome-devtools://devtools/bundled/js_app.html?v8only=true&ws=127.0.0.1:6086/00010002-0003-4004-8005-000600070008](chrome-devtools://devtools/bundled/js_app.html?v8only=true&ws=127.0.0.1:6086/00010002-0003-4004-8005-000600070008)
Copy link
Contributor

@dumganhar dumganhar Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[原生] 修复 JS 原生调试无法使用 Performance 和 Profiler 的问题 #2186

换一个文件名就解决了这个问题?

Copy link
Contributor

@minggo minggo Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的。之前的地址是错误的,那是查看 web 应用的。

@PatriceJiang PatriceJiang deleted the v2.3.1-fix-v8-debug-url branch Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants