Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.4.0 websocket add const fields for instance #2297

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Mar 18, 2020

@PatriceJiang
Copy link
Contributor Author

PatriceJiang commented Mar 18, 2020

@minggo 麻烦review 下

@minggo minggo merged commit 1ce62bf into cocos:v2.4.0 Mar 19, 2020
1 check passed
@minggo
Copy link
Contributor

minggo commented Mar 19, 2020

请同步到 3d, 3d-gfx 分支。

@PatriceJiang
Copy link
Contributor Author

PatriceJiang commented Mar 19, 2020

@minggo 目前这个崩溃只出现在 JavaScriptCore 中, 可以不用 合到 其他分支

@minggo
Copy link
Contributor

minggo commented Mar 20, 2020

Ok

@PatriceJiang
Copy link
Contributor Author

PatriceJiang commented Mar 20, 2020

我发错位置了 😓, websocket 的修改已同步到其他分支.

目前这个崩溃只出现在 JavaScriptCore 中, 可以不用 合到其他分支

应该是这个 #2296

@PatriceJiang PatriceJiang deleted the v2.4.0-websocket-add-const-fields-for-instance branch Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants