Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Socket.IO crash #2338

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Mar 30, 2020

修复,

  • SIO 服务器关闭
  • 本机有代理

的情况下会的现崩溃.

@@ -456,7 +456,7 @@ void SIOClientImpl::handshakeResponse(HttpClient* /*sender*/, HttpResponse *resp
sprintf(statusString, "HTTP Status Code: %ld, tag = %s", statusCode, response->getHttpRequest()->getTag());
CCLOGINFO("response code: %ld", statusCode);

if (!response->isSucceed())
if (!response->isSucceed() || statusCode >= 400)
Copy link
Contributor Author

@PatriceJiang PatriceJiang Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statusCode 为错误码时, 连接不可继续

@holycanvas holycanvas merged commit 9651b02 into cocos:v2.3.3-release Mar 30, 2020
@PatriceJiang PatriceJiang deleted the v2.3.3-release-fix-sio-proxy-crash branch Jun 15, 2020
PatriceJiang added a commit to PatriceJiang/cocos2d-x-lite that referenced this issue Sep 28, 2020
minggo pushed a commit that referenced this issue Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants