Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize editBox fit system window #2630

Merged
merged 2 commits into from Jul 7, 2020
Merged

optimize editBox fit system window #2630

merged 2 commits into from Jul 7, 2020

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Jul 2, 2020

resolve: cocos/2d-tasks#2967

This reverts commit 7274134.

changeLog:
this commit resolve the problem that the game content only shows in the safe area

related bug feedback:
https://discuss.cocos2d-x.org/t/cocos-creator-2-4-0-cant-show-full-screen-android-note-10/50747

@PPpro PPpro changed the base branch from develop to v2.4.1 Jul 2, 2020
@PPpro PPpro marked this pull request as draft Jul 2, 2020
@PPpro PPpro marked this pull request as ready for review Jul 3, 2020
@PPpro PPpro changed the title Revert "set editBox fit system window (#2426)" optimize editBox fit system window Jul 3, 2020
@PPpro
Copy link
Contributor Author

PPpro commented Jul 3, 2020

request review from @minggo

@cocos-robot cocos-robot changed the base branch from v2.4.1 to v2.4.2-release Jul 6, 2020
Copy link
Contributor

@cocos-robot cocos-robot left a comment

We switched this PR to v2.4.2-release because v2.4.1 is about to be deleted.

minggo
minggo approved these changes Jul 7, 2020
@holycanvas holycanvas merged commit 48485c8 into cocos:v2.4.2-release Jul 7, 2020
1 check passed
@PPpro PPpro deleted the 241_safearea branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants