New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prebuilt version of Box2D #18422

Merged
merged 4 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@minggo
Contributor

minggo commented Oct 31, 2017

No description provided.

@minggo minggo added this to the 3.17 milestone Oct 31, 2017

@minggo minggo merged commit b53eb25 into cocos2d:v3 Oct 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Oct 31, 2017

@minggo what exactly Box2D version you are used for this?

KAMIKAZEUA commented Oct 31, 2017

@minggo what exactly Box2D version you are used for this?

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

v2.3.1, the latest released version.

Contributor

minggo commented Nov 1, 2017

v2.3.1, the latest released version.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

@minggo I was sure that your are using not latest version, just asked.
And I already created bug about this before.

KAMIKAZEUA commented Nov 1, 2017

@minggo I was sure that your are using not latest version, just asked.
And I already created bug about this before.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

i used this script to generate it: cocos2d/cocos2d-x-3rd-party-libs-src@b74c095.

Contributor

minggo commented Nov 1, 2017

i used this script to generate it: cocos2d/cocos2d-x-3rd-party-libs-src@b74c095.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I don’t know anything about it. I just know that Box2D is v2.3.2
Better to use original repo of Box2D.

KAMIKAZEUA commented Nov 1, 2017

I don’t know anything about it. I just know that Box2D is v2.3.2
Better to use original repo of Box2D.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor
+BOX2D_VERSION := 2.3.1
 +BOX2D_URL := https://codeload.github.com/erincatto/Box2D/tar.gz/v$(BOX2D_VERSION)

download the source code from github. Does it mean Box2D has wrong version information? And there is not 2.3.2 in https://github.com/erincatto/Box2D/releases.

Contributor

minggo commented Nov 1, 2017

+BOX2D_VERSION := 2.3.1
 +BOX2D_URL := https://codeload.github.com/erincatto/Box2D/tar.gz/v$(BOX2D_VERSION)

download the source code from github. Does it mean Box2D has wrong version information? And there is not 2.3.2 in https://github.com/erincatto/Box2D/releases.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I don’t know anything about releases system on git.
I only know that latest Box2D is v2.3.2, you can check it by yourself too in Box2D sources.
Moreover last commit of Box2D was 4 months ago and that release is 2014 year. It’s obviously that it’s not latest.

KAMIKAZEUA commented Nov 1, 2017

I don’t know anything about releases system on git.
I only know that latest Box2D is v2.3.2, you can check it by yourself too in Box2D sources.
Moreover last commit of Box2D was 4 months ago and that release is 2014 year. It’s obviously that it’s not latest.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

if it is not set a tag to release, then it means it is not about to release? And how to check the Box2D version?

Contributor

minggo commented Nov 1, 2017

if it is not set a tag to release, then it means it is not about to release? And how to check the Box2D version?

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

As I said I don’t know what is releases on git, never used and wanted to use.
Just take Box2D source code, it’s obviously latest and I’m using it for my games.

KAMIKAZEUA commented Nov 1, 2017

As I said I don’t know what is releases on git, never used and wanted to use.
Just take Box2D source code, it’s obviously latest and I’m using it for my games.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA commented Nov 1, 2017

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

erincatto/Box2D@6a38df1, so the author use wrong version information.

You can don't use git release, but i have to use a release version to make sure that it is a release version.

Contributor

minggo commented Nov 1, 2017

erincatto/Box2D@6a38df1, so the author use wrong version information.

You can don't use git release, but i have to use a release version to make sure that it is a release version.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

Oh, my fault. The version is changed after releasing 2.3.1. But the author doesn't release 2.3.2. Then i don't know use which commit to build Box2D.

Contributor

minggo commented Nov 1, 2017

Oh, my fault. The version is changed after releasing 2.3.1. But the author doesn't release 2.3.2. Then i don't know use which commit to build Box2D.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I’m using latest code just it’s simpler, I don’t understand why you not sure.

KAMIKAZEUA commented Nov 1, 2017

I’m using latest code just it’s simpler, I don’t understand why you not sure.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

I created an issue: erincatto/Box2D#478 to ask the author when to release 2.3.2.

Contributor

minggo commented Nov 1, 2017

I created an issue: erincatto/Box2D#478 to ask the author when to release 2.3.2.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I don’t think he will answer)

KAMIKAZEUA commented Nov 1, 2017

I don’t think he will answer)

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

Use latest github codes is dangerous. You can use it in your project, it is ok, it is just your own project. But cocos2d-x is used in many games, we should make sure to use stable version.

Contributor

minggo commented Nov 1, 2017

Use latest github codes is dangerous. You can use it in your project, it is ok, it is just your own project. But cocos2d-x is used in many games, we should make sure to use stable version.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I’m using latest for a long time. It’s obviously for me that I should use latest code. If you want make sure and test it or not , no problem.
Do you think author of Box2D testing it really? Not more than testbed App, lol.
Anyway after you used not latest prebuilt Box2D and I update cocos - how I should update it by myself? Currently it’s in external folder so I can just copy paste code. But with prebuilt how I can update it?

KAMIKAZEUA commented Nov 1, 2017

I’m using latest for a long time. It’s obviously for me that I should use latest code. If you want make sure and test it or not , no problem.
Do you think author of Box2D testing it really? Not more than testbed App, lol.
Anyway after you used not latest prebuilt Box2D and I update cocos - how I should update it by myself? Currently it’s in external folder so I can just copy paste code. But with prebuilt how I can update it?

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

https://github.com/cocos2d/cocos2d-x-3rd-party-libs-src, it supports to build prebuilt versions. About Windows, it is easy to use VS to build libs.

Contributor

minggo commented Nov 1, 2017

https://github.com/cocos2d/cocos2d-x-3rd-party-libs-src, it supports to build prebuilt versions. About Windows, it is easy to use VS to build libs.

@vkreal

This comment has been minimized.

Show comment
Hide comment
@vkreal

vkreal Nov 1, 2017

I have a custom version of Box2d and since cocos now uses prebuilt how can I use my version. I dont have Windows. What i have done when after upgrading cocos replace the box2d files.

vkreal commented Nov 1, 2017

I have a custom version of Box2d and since cocos now uses prebuilt how can I use my version. I dont have Windows. What i have done when after upgrading cocos replace the box2d files.

@vkreal

This comment has been minimized.

Show comment
Hide comment
@vkreal

vkreal Nov 1, 2017

Maybe making box2d prebuilt is not the way to go?

vkreal commented Nov 1, 2017

Maybe making box2d prebuilt is not the way to go?

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

Minggo just use latest code, I’ve used it for years with couple big games and it’s stable.
You really thinking that author of Box2D will test it like in games or cocos before release? Don’t make me laugh.. he just will click: release-> v2.3.2 -> done. Here you go ))

KAMIKAZEUA commented Nov 1, 2017

Minggo just use latest code, I’ve used it for years with couple big games and it’s stable.
You really thinking that author of Box2D will test it like in games or cocos before release? Don’t make me laugh.. he just will click: release-> v2.3.2 -> done. Here you go ))

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

@KAMIKAZEUA which is the latest one? It is changed 5 months ago, and you used it for years, did you mean we have to update it when there is a new commit?

@vkreal you can change to use source code, it is not so hard. In fact, all 3rd part libs should use prebuilt version. It will speed up building speed and fix many warnings. The final goal is to remove all warnings, then make warnings as error.

Contributor

minggo commented Nov 1, 2017

@KAMIKAZEUA which is the latest one? It is changed 5 months ago, and you used it for years, did you mean we have to update it when there is a new commit?

@vkreal you can change to use source code, it is not so hard. In fact, all 3rd part libs should use prebuilt version. It will speed up building speed and fix many warnings. The final goal is to remove all warnings, then make warnings as error.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I’m telling that I’m always using latest code from git for years(follow any Box2D code updates) and never faced problems.

KAMIKAZEUA commented Nov 1, 2017

I’m telling that I’m always using latest code from git for years(follow any Box2D code updates) and never faced problems.

@vkreal

This comment has been minimized.

Show comment
Hide comment
@vkreal

vkreal Nov 1, 2017

@minggo fair enough about the fixing warnings.

vkreal commented Nov 1, 2017

@minggo fair enough about the fixing warnings.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

Yep, then when to update Box2D? Every time it has a new commit? And you can use the script to build prebuilt version if you want.

Indeed, cocos2d-x doesn't depend on Box2D, i can adjust the project settings to remove it from linking. Then you guys can determine how to use it.

Contributor

minggo commented Nov 1, 2017

Yep, then when to update Box2D? Every time it has a new commit? And you can use the script to build prebuilt version if you want.

Indeed, cocos2d-x doesn't depend on Box2D, i can adjust the project settings to remove it from linking. Then you guys can determine how to use it.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

Every time yes, it’s like every day? No, check timeline of commits and you will understand.

KAMIKAZEUA commented Nov 1, 2017

Every time yes, it’s like every day? No, check timeline of commits and you will understand.

@vkreal

This comment has been minimized.

Show comment
Hide comment
@vkreal

vkreal Nov 1, 2017

@minggo i can adjust the project settings to remove it from linking lets keep it the way it is now :)

vkreal commented Nov 1, 2017

@minggo i can adjust the project settings to remove it from linking lets keep it the way it is now :)

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I’m suggesting you remove anything else that not depends, currently engine is too heavy and compiling is a nightmare. What is pity that many of thing is never ever used by recompile’s every time..

KAMIKAZEUA commented Nov 1, 2017

I’m suggesting you remove anything else that not depends, currently engine is too heavy and compiling is a nightmare. What is pity that many of thing is never ever used by recompile’s every time..

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

@KAMIKAZEUA i will create a discuss thread in forum. I think listening other developers' opinion is good. I will paste the link here. Yep, that's why i use prebuilt version. I will continue to have more prebuilt version of other codes, such as 3d related codes.

@vkreal thanks for understanding.

Contributor

minggo commented Nov 1, 2017

@KAMIKAZEUA i will create a discuss thread in forum. I think listening other developers' opinion is good. I will paste the link here. Yep, that's why i use prebuilt version. I will continue to have more prebuilt version of other codes, such as 3d related codes.

@vkreal thanks for understanding.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I’ve already a nightmare experience with building prebuilt libs of cocos and now I would need also play with other not needed compiling.. ohh

KAMIKAZEUA commented Nov 1, 2017

I’ve already a nightmare experience with building prebuilt libs of cocos and now I would need also play with other not needed compiling.. ohh

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 1, 2017

I actually don’t care what other devs will say, I just need to be able to use latest v2.3.2 Box2D, that’s it. And what if I have custom Box2D code? Or I don't have windows to recompile libs? Or I have to do too much to replace box2d lib now..
And I was sure that with this merge it’s not latest, that’s why I wrote.

KAMIKAZEUA commented Nov 1, 2017

I actually don’t care what other devs will say, I just need to be able to use latest v2.3.2 Box2D, that’s it. And what if I have custom Box2D code? Or I don't have windows to recompile libs? Or I have to do too much to replace box2d lib now..
And I was sure that with this merge it’s not latest, that’s why I wrote.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 1, 2017

Contributor

I create a thread here: http://discuss.cocos2d-x.org/t/use-which-version-of-box2d/39758.

@KAMIKAZEUA the engine is not just for you.

Contributor

minggo commented Nov 1, 2017

I create a thread here: http://discuss.cocos2d-x.org/t/use-which-version-of-box2d/39758.

@KAMIKAZEUA the engine is not just for you.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 4, 2017

Just add two options: prebuilt lib 3y old and prebuilt lib using latest commit. In cocos config change that. My game code can’t be even compiled with old one. And there are a lot of fixes I need for stable work of my game.

KAMIKAZEUA commented Nov 4, 2017

Just add two options: prebuilt lib 3y old and prebuilt lib using latest commit. In cocos config change that. My game code can’t be even compiled with old one. And there are a lot of fixes I need for stable work of my game.

@minggo minggo deleted the minggo:box2d-prebuilt branch Nov 7, 2017

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 15, 2017

@minggo when you will remove Box2D from cocos2d-x remove all results of macro: CC_ENABLE_BOX2D_INTEGRATION from cocos2d-x. THanks.

screen shot

And any Box2D specific code:

screen shot

KAMIKAZEUA commented Nov 15, 2017

@minggo when you will remove Box2D from cocos2d-x remove all results of macro: CC_ENABLE_BOX2D_INTEGRATION from cocos2d-x. THanks.

screen shot

And any Box2D specific code:

screen shot

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 15, 2017

Contributor

Oh, i don't notice that some codes depends on Box2D. Then i can not remove it.

Contributor

minggo commented Nov 15, 2017

Oh, i don't notice that some codes depends on Box2D. Then i can not remove it.

@KAMIKAZEUA

This comment has been minimized.

Show comment
Hide comment
@KAMIKAZEUA

KAMIKAZEUA Nov 16, 2017

@minggo revert back to source code, as it was before. Or use latest commit as in vote.

KAMIKAZEUA commented Nov 16, 2017

@minggo revert back to source code, as it was before. Or use latest commit as in vote.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo

minggo Nov 17, 2017

Contributor

Yep, i think i have to use latest commit as in vote.

Contributor

minggo commented Nov 17, 2017

Yep, i think i have to use latest commit as in vote.

@minggo

This comment has been minimized.

Show comment
Hide comment
@minggo
Contributor

minggo commented Nov 17, 2017

stevetranby added a commit to stevetranby/cocos2d-x that referenced this pull request Nov 21, 2017

Merge commit 'b53eb252005ee92773f6cd9f66191cf99ad2320a' into scgamex-v3
* commit 'b53eb252005ee92773f6cd9f66191cf99ad2320a':
  use prebuilt version of Box2D (cocos2d#18422)

# Conflicts:
#	build/cocos2d_libs.xcodeproj/project.pbxproj
#	cocos/Android.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment