Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <uses-feature android:glEsVersion="0x00020000"/> to AndroidManifest #1872

Merged
merged 1 commit into from Jan 22, 2013

Conversation

moadib
Copy link
Contributor

@moadib moadib commented Jan 21, 2013

Since cocos2d-x uses gles20 we should have this for proper Google Play filtering

Here is note about it http://developer.android.com/reference/android/opengl/GLSurfaceView.html#setEGLContextClientVersion(int)

@dumganhar
Copy link

Could users download and install gles20 application if without adding this to AndroidManifest.xml?

@moadib
Copy link
Contributor Author

moadib commented Jan 22, 2013

Yes they can. But users with devices which doesn't support gles20 can too and then they would damn you in reviews because application doesn't work.

It is allows Google Play to filter your application to users who can use it.

dumganhar pushed a commit that referenced this pull request Jan 22, 2013
fixed #1673: Added <uses-feature android:glEsVersion="0x00020000"/> to AndroidManifest.
@dumganhar dumganhar merged commit b2179fb into cocos2d:master Jan 22, 2013
@dumganhar
Copy link

Thank you.

angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
fixed cocos2d#1673: Added <uses-feature android:glEsVersion="0x00020000"/> to AndroidManifest.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
fixed cocos2d#1673: Added <uses-feature android:glEsVersion="0x00020000"/> to AndroidManifest.
dumganhar pushed a commit that referenced this pull request May 4, 2014
fixed #1673: Added <uses-feature android:glEsVersion="0x00020000"/> to AndroidManifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants