New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatchEvent will now also dispatch from _tooAddListeners for CUSTOM type #19262

Open
wants to merge 2 commits into
base: v3
from

Conversation

Projects
None yet
2 participants
@benjaprieto
Copy link
Contributor

benjaprieto commented Dec 21, 2018

EventDispatcher::dispatchEvent will now also dispatch CUSTOM events from the new listeners listed in _tooAddListeners, that might been added while dispatching. This helps avoid some order/timing logic issues difficult to track.

  • Change done for Crowdstar Cocos2DX projects -
EventDispatcher::dispatchEvent will now also dispatch event from the …
…new listeners listed in _tooAddListeners, that might been added while dispatching. This helps avoid some order/timing logic issues difficult to track.
@PatriceJiang

This comment has been minimized.

Copy link
Collaborator

PatriceJiang commented Dec 29, 2018

@benjaprieto Could you please add a new test case in the cpp-tests project?

Added new case for EventDispatcherTest to test adding a custom dispat…
…cher event while iterating through the pending custom event to verify calling order
@benjaprieto

This comment has been minimized.

Copy link
Contributor

benjaprieto commented Jan 10, 2019

@benjaprieto Could you please add a new test case in the cpp-tests project?

I have added a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment