fix WebSocket url parse error for 'ws://domain.com/websocket' pattern #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
pushed a commit
that referenced
this pull request
Jun 19, 2013
closed #2312: WebSocket url parse error for 'ws://domain.com/websocket' pattern
|
Thanks. |
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
closed cocos2d#2312: WebSocket url parse error for 'ws://domain.com/websocket' pattern
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
closed cocos2d#2312: WebSocket url parse error for 'ws://domain.com/websocket' pattern
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
closed cocos2d#2312: WebSocket url parse error for 'ws://domain.com/websocket' pattern
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
closed cocos2d#2312: WebSocket url parse error for 'ws://domain.com/websocket' pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing code only works fine for ws://domain.com, but not for ws://domain.com/websocket. it will be parsed as
_host = "domain.com/websocket"
_port = 80
_path = "/"
the correct parse should be:
_host = "domain.com"
_port = 80
_path = "/websocket"
this patch also works for "ws://domain.com:8080/websocket"