Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pascalcase to v2 #2479

Closed
wants to merge 1 commit into from

Conversation

krypton-build-user
Copy link
Collaborator

@krypton-build-user krypton-build-user commented Mar 3, 2023

This PR contains the following updates:

Package Type Update Change
pascalcase dependencies major 1.0.0 -> 2.0.0

Release Notes

jonschlinkert/pascalcase

v2.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Self-Hosted Renovate Bot. Find all logs here.

@krypton-build-user krypton-build-user requested a review from a team as a code owner March 3, 2023 00:58
@krypton-build-user krypton-build-user added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code renovate labels Mar 3, 2023
@dweitzman-codaio
Copy link
Contributor

This can be test case for #2478

This PR would need to rebuild the thunk. Ideally we can make renovate do that automatically

@jonathan-codaio
Copy link
Collaborator

@dweitzman-codaio I think bumping this breaks the way we normalize column names, this was a longstanding issue that we finally understood better recently: https://codaproject.slack.com/archives/C02K6EABVMK/p1673551144680909

I thought there was a test that would catch this and that we maybe had the version pinned on yarn or told dependabot to ignore this version, we may need to do the same for Renovate.

@dweitzman-codaio
Copy link
Contributor

The test may be working. This PR didn't get as far as running the tests because of the frozen lockfile pr earlier today

I have a fix pending review for renovate so it will update the lockfile

@dweitzman-codaio
Copy link
Contributor

My attempt to get renovate to update the generated files didn't work. I'm not going to look into this more for now, so closing the PR

@krypton-build-user
Copy link
Collaborator Author

krypton-build-user commented Mar 6, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@krypton-build-user krypton-build-user deleted the renovate/pascalcase-2.x branch March 6, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants