Upgrade python deps with "pipenv update" #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-codaio
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Not important enough to spend time on now, but I wonder if we should just change requirements.txt to just be manually updated like one would expect, and engineers would keep it updated as needed when readthedocs changes vs generating it. I think it's a bit counterintuitive right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txtis actually a generated file in packs-sdk, so the renovate PRs to modify it will get undone by anyone runningmake bsSeems like we'll need to manually update Pipfile dependencies from time to time with
pipenv update, unless renovate figures out how to do the right thing after we hide the requirements.txt file from it?...