Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor automated CI #118

Closed
wants to merge 1 commit into from

Conversation

@ccoenen
Copy link

commented Jul 17, 2015

This adds an appveyor.yml. Appveyor is similar to Travis, but runs on a windows host. This will make sure that build problems on windows surface early.

Example output can be seen here: https://ci.appveyor.com/project/ccoenen/bcrypt-ruby/build/5 (one build timeouted in bundler, everything else ran fine).

@ccoenen

This comment has been minimized.

Copy link
Author

commented Jul 17, 2015

caveat: this would not have spotted #116, as that was a problem with the precompiled gem.

@tenderlove tenderlove closed this Oct 27, 2015

@tenderlove tenderlove reopened this Oct 27, 2015

@tenderlove

This comment has been minimized.

Copy link
Collaborator

commented Oct 27, 2015

(Bumping for CI, sorry about the noise)

@tjschuck

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2018

Historically, our issue hasn't really been running the tests on Windows, but rather installing the pre-compiled versions of the gem (like you pointed out in your last comment). Using AppVeyor to run the tests is interesting, but not nearly as compelling and useful as using AppVeyor to install the gem — that's what was done in #171.

Closing this in favor of that. Thanks for submitting your contribution, though!

@tjschuck tjschuck closed this May 15, 2018

@ccoenen

This comment has been minimized.

Copy link
Author

commented May 15, 2018

Fine with me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.