This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Expose personalization, salt, tree hashing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing mode The outputs in examples have been verified by porting the example to https://github.com/dchest/blake2b, and verifying that the output matches. It seems the Blake2 reference itself does not contain sample data. The C implementation has been extended with the function blake2b_init_parametrized, as the existing API did not seem to expose the functionality; blake2b_init_param was enough for tree mode et al, yet the keying was only in blake2b_init_key, which hardcoded parameters. See BLAKE2/BLAKE2#8 for more.
Calling code will often want to make buffers of these sizes.
|
Sounds good to me! |
codahale
added a commit
that referenced
this pull request
Aug 20, 2014
Expose personalization, salt, tree hashing
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'd like to use more of the functionality of blake2b, and will happily contribute code exposing more of the blake2 functionality. Is this ok with you?
I'm thinking of adding a type Config with all the possible settings, and then a func New(*Config) hash.Hash. How does that sound to you? blake2.New(nil) can behave like the current NewBlake2B. No need for backwards-incompatible changes.