Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function can be simplified #301

Open
code423n4 opened this issue Apr 28, 2021 · 0 comments
Open

Function can be simplified #301

code423n4 opened this issue Apr 28, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Collaborator

Handle

s1m0

Vulnerability details

Impact

voteProposal can be simplified,

Proof of Concept

https://github.com/code-423n4/2021-04-vader/blob/main/vader-protocol/contracts/DAO.sol#L83

Tools Used

Manual analysis

Recommended Mitigation Steps

if(hasMajority(proposalID) && (isEqual(_type, 'DAO') || isEqual(_type, 'UTILS') || isEqual(_type, 'REWARD')))
check the condition on line 84 in the outer if.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 28, 2021
code423n4 added a commit that referenced this issue Apr 28, 2021
@code423n4
s1m0 issue #301
a9e9262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4