Lack of zero address validation

[code423n4]

Handle

JMukesh

Vulnerability details

Impact

constructor of RCorderbook.sol lacks zero address validation , since parameter of costructor are used initialize state variable which are used in other function of the contract , error in these state variable can lead to redeployment of contract

Proof of Concept

https://github.com/code-423n4/2021-06-realitycards/blob/main/contracts/RCOrderbook.sol#L106

Tools Used

manual review

Recommended Mitigation Steps

add require condition to check for zero address

[Splidge]

I think the zero address validation isn't a problem for factoryAddress as this can be set later in the function setFactoryAddress
However yes Treasury is missing a possible setTreasuryAddress

[Splidge]

implemented here

[Splidge]

Additional changes for #142 and #115 are here