Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded iteration over all premium tokens #102

Open
code423n4 opened this issue Jul 28, 2021 · 0 comments
Open

Unbounded iteration over all premium tokens #102

code423n4 opened this issue Jul 28, 2021 · 0 comments
Labels
1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The Gov.protocolRemove function iterates over all elements of the tokensSherX array.

Impact

The transactions could fail if the arrays get too big and the transaction would consume more gas than the block limit.
This will then result in a denial of service for the desired functionality and break core functionality.

The severity is low as only governance can whitelist these tokens but not the protocols themselves.

Recommendation

Keep the array size small.

@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Jul 28, 2021
code423n4 added a commit that referenced this issue Jul 28, 2021
@Evert0x Evert0x added the sponsor acknowledged Sponsor acknowledged, but not resolving label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
Projects
None yet
Development

No branches or pull requests

2 participants