Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing comment in protocolUpdate #19

Open
code423n4 opened this issue Jul 25, 2021 · 0 comments
Open

confusing comment in protocolUpdate #19

code423n4 opened this issue Jul 25, 2021 · 0 comments
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed Sponsor confirmed issue

Comments

@code423n4
Copy link
Contributor

Handle

gpersoon

Vulnerability details

Impact

The comment "NOTE: UNUSED" can be interpreted that both protocolManagers and protocolAgents are unused. See proof of concept below.
However only protocolManagers is unused.

Proof of Concept

//https://github.com/code-423n4/2021-07-sherlock/blob/main/contracts/facets/Gov.sol#L148
function protocolUpdate( bytes32 _protocol, address _eoaProtocolAgent,address _eoaManager) public override onlyGovMain {
...
// NOTE: UNUSED
gs.protocolManagers[_protocol] = _eoaManager;
gs.protocolAgents[_protocol] = _eoaProtocolAgent;
}

Tools Used

Recommended Mitigation Steps

Change the comment to:
// NOTE: protocolManagers UNUSED

@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jul 25, 2021
code423n4 added a commit that referenced this issue Jul 25, 2021
@Evert0x Evert0x added the sponsor confirmed Sponsor confirmed issue label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed Sponsor confirmed issue
Projects
None yet
Development

No branches or pull requests

2 participants