We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defsec
There is occurrence in the code of the TransferHelper contract where amount is checked after the external call.
None
To favor readability and avoid confusions, consider applying check at the beginning of function.
function _safeTransferFrom(address _token, address _sender, uint _amount) internal virtual { require(_amount > 0, "TransferHelper: amount must be > 0"); ... }
The text was updated successfully, but these errors were encountered:
defsec issue #56
eb746c4
Readability issues should IMO be marked as 0 (non-critical).
Sorry, something went wrong.
This is gas optimization since I don't see any exploit.
No branches or pull requests
Handle
defsec
Vulnerability details
Impact
There is occurrence in the code of the TransferHelper contract where amount is checked after the external call.
Proof of Concept
Tools Used
None
Recommended Mitigation Steps
To favor readability and avoid confusions, consider applying check at the beginning of function.
The text was updated successfully, but these errors were encountered: