Appropriate storage variable type declaration to save on casting

[code423n4]

Handle

hickuphh3

Vulnerability details

Impact

By declaring appropriate variable types to storage variables, unnecessary / fewer type casting can be avoided.

Recommended Mitigation Steps

LongShort.sol

1. mapping(uint32 => int256) public assetPrice;
2. mapping(uint32 => IYieldManager) public yieldManagers;
3. mapping(uint32 => IERC20) public paymentTokens;
4. mapping(uint32 => IOracleManager) public oracleManagers;
5. mapping(uint32 => mapping(bool => ISyntheticToken)) public syntheticTokens;

SyntheticToken.sol

1. IStaker public staker;

Staker.sol

1. IFloatToken public floatToken;
2. ILongShort public longShort;

[JasoonS]

This breaks hardhat stack traces :( We had all our code like this originally, and I DO prefer it like that!

No effect on gas though (casting that is).

NomicFoundation/hardhat#1564

[0xean]

There are gas costs associated with casting int256 -> uint256.