Unused named returns can be removed for optimization

[code423n4]

Handle

0xRajeev

Vulnerability details

Impact

Named returns are ignored in several places to favor explicit returns. Removing such named return variables can optimize a little gas and improve readability.

Proof of Concept

https://github.com/code-423n4/2021-08-floatcapital/blob/bd419abf68e775103df6e40d8f0e8d40156c2f81/contracts/contracts/LongShort.sol#L401

https://github.com/code-423n4/2021-08-floatcapital/blob/bd419abf68e775103df6e40d8f0e8d40156c2f81/contracts/contracts/LongShort.sol#L415

https://github.com/code-423n4/2021-08-floatcapital/blob/bd419abf68e775103df6e40d8f0e8d40156c2f81/contracts/contracts/Staker.sol#L453

https://github.com/code-423n4/2021-08-floatcapital/blob/bd419abf68e775103df6e40d8f0e8d40156c2f81/contracts/contracts/Staker.sol#L537

Tools Used

Manual Analysis

Recommended Mitigation Steps

Remove unused named return variables.

[JasoonS]

Thank you.

I didn't think about gas implications, but makes sense.

We have some codegen stuff that uses the return value name which is quite nice.