Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead code #87

Open
code423n4 opened this issue Sep 15, 2021 · 1 comment
Open

Dead code #87

code423n4 opened this issue Sep 15, 2021 · 1 comment
Labels
bug Warden finding G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

rate state variable in MinterWrapper is practically useless as it is not used in any meaningful way.
event InsuranceClaimed is declared but never emitted. Same with events VaultManagerSet and ControllerSet.

Recommended Mitigation Steps

Consider removing dead code.
code423n4 added a commit that referenced this issue Sep 15, 2021
@code423n4
pauliax issue #87
ee3c7bd
@Haz077 Haz077 added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Sep 25, 2021
@GalloDaSballo
Copy link
Collaborator

Evidence from code provided does agree with warden finding

Sponsor disputed

Will keep issue as valid as it may be because of some issue with the repo, however sponsor shouldn't have to mitigate as at worst this is a waste of gas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @Haz077