Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurveModule: Redundant jToken #39

Open
code423n4 opened this issue Nov 1, 2021 · 0 comments
Open

CurveModule: Redundant jToken #39

code423n4 opened this issue Nov 1, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

hickuphh3

Vulnerability details

Impact

jToken is unused within the function, and therefore can be removed. While it can used to check against ICurvePool(curvePool).coins(j) to ensure that the user is swapping for the right token, it isn't necessary because the final token balance is checked after all trades are executed.

Recommended Mitigation Steps

Remove the jToken input parameter.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 1, 2021
code423n4 added a commit that referenced this issue Nov 1, 2021
@code423n4
hickuphh3 issue #39
d3e62b3
@tommyz7 tommyz7 mentioned this issue Nov 4, 2021
Closed
@tommyz7 tommyz7 added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommyz7 @code423n4