Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require should come first #93

Open
code423n4 opened this issue Nov 22, 2021 · 0 comments
Open

require should come first #93

code423n4 opened this issue Nov 22, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

Vulnerability details

OverlayToken.sol line 131/180/254:
the require comes after the _transfer function, there is no reason for it to be after the function.
If the require is placed before the _transfer it will save gas if the require will fail.

Tool Used

Manual code review.

Recommended Mitigation Steps

place the _transfer after the require
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 22, 2021
code423n4 added a commit that referenced this issue Nov 22, 2021
@code423n4
pants issue #93
4968dbc
@mikeyrf mikeyrf added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeyrf @code423n4