Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 valueInETH #239

Open
code423n4 opened this issue Nov 24, 2021 · 0 comments
Open

0 valueInETH #239

code423n4 opened this issue Nov 24, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

valueInETH can be 0 when the token is not native but oracle is not set for it. Consider skipping all the expensive calculations in recordKeyPurchase to save gas when valueInETH is 0. Also, in special cases, this can invoke a division by zero runtime error when calculating maxTokens and dividing by grossNetworkProduct.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 24, 2021
code423n4 added a commit that referenced this issue Nov 24, 2021
@code423n4
pauliax issue #239
f8abbf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4