Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas savings #139

Open
code423n4 opened this issue Dec 21, 2021 · 0 comments
Open

Gas savings #139

code423n4 opened this issue Dec 21, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

csanuragjain

Vulnerability details

Impact

Gas wastage

Proof of Concept

  1. Navigate to contract at https://github.com/code-423n4/2021-12-yetifinance/blob/main/packages/contracts/contracts/Dependencies/YetiCustomBase.sol

  2. Observe that in _subColls function the last for loop is not required if n=0 since this means that all token amount is 0
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 21, 2021
code423n4 added a commit that referenced this issue Dec 21, 2021
@code423n4
csanuragjain issue #139
4608e4f
@kingyetifinance kingyetifinance added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 6, 2022
@0xtruco 0xtruco mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @kingyetifinance