Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare state variables as immutable #162

Open
code423n4 opened this issue Dec 21, 2021 · 1 comment
Open

Declare state variables as immutable #162

code423n4 opened this issue Dec 21, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

p4st13r4

Vulnerability details

Impact

In WJLP.sol, state variables JLP and JOE are initialized in the constructor and never reassigned again. Thus, they can be declared immutable rather than constant in order to save gas

Proof of Concept

https://github.com/code-423n4/2021-12-yetifinance/blob/main/packages/contracts/contracts/AssetWrappers/WJLP/WJLP.sol#L41

Tools Used

Editor
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 21, 2021
code423n4 added a commit that referenced this issue Dec 21, 2021
@code423n4
p4st13r4 issue #162
ea6ee33
@kingyetifinance
Copy link
Collaborator

@LilYeti: Again similar to #10 and #148 and #132 but different variables

@kingyetifinance kingyetifinance added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 6, 2022
@0xtruco 0xtruco mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @kingyetifinance