Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open TODOs #96

Closed
code423n4 opened this issue Jan 10, 2022 · 2 comments · Fixed by lindy-labs/sc_solidity-contracts#25
Closed

Open TODOs #96

code423n4 opened this issue Jan 10, 2022 · 2 comments · Fixed by lindy-labs/sc_solidity-contracts#25
Assignees
@naps62
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

Impact

Open TODOs can point to architecture or programming issues that still need to be resolved.

Proof of Concept

The TODOs are here:

contracts\vault\Claimers.sol:32:    // TODO Make names dynamic
contracts\vault\Depositors.sol:43:    // TODO: emit the groupId
contracts\Vault.sol:291:        // TODO no invested amount yet
contracts\Vault.sol:637:            // TODO exclude sponsored assets

Tools Used

VS Code

Recommended Mitigation Steps

Consider resolving the TODOs before deploying.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 10, 2022
code423n4 added a commit that referenced this issue Jan 10, 2022
@code423n4
Dravee issue #96
9794648
@r2moon r2moon added disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) duplicate This issue or pull request already exists labels Jan 11, 2022
@r2moon
Copy link
Collaborator

r2moon commented Jan 11, 2022

duplicated with #69

@dmvt dmvt mentioned this issue Jan 28, 2022
Closed
@dmvt dmvt removed the duplicate This issue or pull request already exists label Jan 28, 2022
@dmvt
Copy link
Collaborator

dmvt commented Jan 28, 2022

I'm going to make this the main one since it highlights all 4 of the TODOs

@dmvt dmvt reopened this Jan 28, 2022
This was referenced Jan 28, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@naps62 naps62 mentioned this issue Feb 21, 2022
Merged
@naps62 naps62 self-assigned this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naps62 naps62

Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds correct name and symbol to NFTs lindy-labs/sc_solidity-contracts
5 participants
@naps62 @dmvt @r2moon @code423n4 @CloudEllie