Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #25

Open
code423n4 opened this issue Mar 23, 2022 · 1 comment
Open

QA Report #25

code423n4 opened this issue Mar 23, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Missing Zero Chcks

impact

Zero-address checks for input validation of address-type variables is a best-practice. While this is implemented in some places, there are missing ones.

POC

https://github.com/code-423n4/2022-03-rolla/blob/a06418c9cc847395f3699bdf684a9ac066651ed7/quant-protocol/contracts/
QuantCalculator.sol#L55-L57

strikeAssetDecimals and optionsFactory variables do not perform zero checks which could result in lose of funds or malfunctions.

Tools Used

Manual Analysis

Recommended Mitigation Steps

Add zero-address checks

Arbitrary send

https://github.com/code-423n4/2022-03-rolla/blob/a06418c9cc847395f3699bdf684a9ac066651ed7/quant-protocol/contracts/timelock/TimelockController.sol#L414

impact

Unprotected call to a function sending Ether to an arbitrary address.

Tools Used

Manual Analysis

Recommended Mitigation Steps

Ensure that an arbitrary user cannot withdraw unauthorized funds.
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 23, 2022
code423n4 added a commit that referenced this issue Mar 23, 2022
@code423n4
badbird issue #25
71964fd
@0xca11 0xca11 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Apr 8, 2022
@alcueca
Copy link
Collaborator

alcueca commented Apr 12, 2022

Score: 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alcueca @0xca11 @code423n4