QA Report

[code423n4]

Typo

Details

A typo in the comment; MANGER instead of MANAGER. Check for exact spelling to make the documentation clear.

Affected code :

https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/index-coop-notional-trade-module/contracts/protocol/modules/v1/NotionalTradeModule.sol#L215

---

Use of pragma experimental ABIEncoderV2

Details

According to the solidity documentation (https://docs.soliditylang.org/en/v0.8.13/080-breaking-changes.html): The pragma pragma experimental ABIEncoderV2; is still valid, but it is deprecated and has no effect.

Mitigation

If you want to be explicit, please use pragma abicoder v2; instead.

affected code:

https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/notional-wrapped-fcash/contracts/wfCashLogic.sol#L3

---

Outdated Solidity version in use

Details

Outdated version of Solidity are being used in one of the contracts. Throughout the codebase there are also different versions of Solidity being used.

Mitigation

Consider using a more recent version of the compiler, such as version 0.8.11. And also to avoid unexpected behavior, consider specifying explicit Solidity versions in pragma statements.

Affected code:

https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/index-coop-notional-trade-module/contracts/protocol/modules/v1/NotionalTradeModule.sol#L19
https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/notional-wrapped-fcash/contracts/wfCashERC4626.sol#L2