Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to set CURVE_POOL approval after setting new curve pool address #165

Open
code423n4 opened this issue Jun 26, 2022 · 1 comment
Open

No way to set CURVE_POOL approval after setting new curve pool address #165

code423n4 opened this issue Jun 26, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-yieldy/blob/524f3b83522125fb7d4677fa7a7e5ba5a2c0fe67/src/contracts/Staking.sol#L157-L160

Vulnerability details

Impact

Staking.setCurvePool() allows the owner to set a new CURVE_POOL address, however, there is no way to set token approvals to the new address. The only calls to token.approve() are found in the constructor. Therefore, there's no true way to set a new curve pool. All calls to ICurvePool(CURVE_POOL).exchange() will fail.

Tools Used

Manual review.

Recommended Mitigation Steps

Set approvals for the new curve pool address in the same setCurvePool() function.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jun 26, 2022
code423n4 added a commit that referenced this issue Jun 26, 2022
@code423n4
0xDjango issue #165
19a8890
@toshiSat
Copy link
Collaborator

duplicate #133

@toshiSat toshiSat added the duplicate This issue or pull request already exists label Jun 27, 2022
This was referenced Jun 27, 2022
Closed
Closed
Closed
Closed
@JeeberC4 JeeberC4 removed the duplicate This issue or pull request already exists label Aug 12, 2022
@JeeberC4 JeeberC4 reopened this Aug 12, 2022
This was referenced Aug 26, 2022
Closed
Closed
Closed
@0xean 0xean added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@toshiSat @0xean @code423n4 @itsmetechjay @JeeberC4