Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #177

Open
code423n4 opened this issue Jun 26, 2022 · 0 comments
Open

QA Report #177

code423n4 opened this issue Jun 26, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

1) affiliateFee should have an upper limit to avoid abuse.

affiliateFee

2) Grammatical mistakes in natspec comments:

a) this is function is called

b) @dev this allows us to change how much time before the end of the cycle we send the withdraw requests
should be "we can send" and not "we send"

3) Grammatical errors in normal comments:

a) asdf

b) // try to claim withdraw if user has withdraws to claim function will check if withdraw is valid

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 26, 2022
code423n4 added a commit that referenced this issue Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant