QA Report #344
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Report
Low Risk
[L-01]: Loops may exceed gas limit
Context:
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L353
Description:
Either explicitly or just due to normal operation, the number of iterations in a loop can grow beyond the block gas limit, which can cause the complete contract to be stalled at a certain point.
Non-Critical Issues
[N-01]: Floating Pragma
Context:
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/token/VariableSupplyERC20Token.sol#L2
Recommendation:
https://swcregistry.io/docs/SWC-103
Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.
[N-02]: Public function can be external
Context:
Description:
Public functions can be declared external if they are not called by the contract.
Recommendation:
Declare these functions as external instead of public.
[N-03]: NatSpec is missing
Context:
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/token/FullPremintERC20Token.sol
[N-04]: NatSpec is incomplete
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/token/VariableSupplyERC20Token.sol#L36
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/AccessProtected.sol#L29
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L56
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L61
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L66
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L74
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L77
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L86
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L95
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L119
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L142
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L190
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L201
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L211
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L220
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L227
https://github.com/code-423n4/2022-09-vtvl/blob/main/contracts/VTVLVesting.sol#L414
The text was updated successfully, but these errors were encountered: