Skip to content

Mitigation Confirmed for GAS #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
code423n4 opened this issue Mar 20, 2023 · 1 comment
Open

Mitigation Confirmed for GAS #17

code423n4 opened this issue Mar 20, 2023 · 1 comment
Labels
mitigation-confirmed MR-Gas satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Issue #21

KBC-01G - cBond changed from memory to calldata. No new issue created.

KBC-02G - redeem now only loads the parentId into memory instead of the entire cBond. No new issue created.

KIB-01G - _allowances is private and never used so it has been removed. No new issue created.

KIB-02G - this.balanceOf(to) changed to balanceOf(to) in 4 locations. No new issue created.

KFC-02G - i is incremented inside an unchecked block. Since i is only used to track the number of loops, the change is safe and no new issues have been created.

KFC-03G - It appears that this was meant to reference KFC-04G instead of KFC-03G because no changes have been made to address this.

KFC-04G - Storage variables are only written once at the end of instead of each loop. No new issue created.

KBT-01G - _beforeTokenTransfer is overriden instead of transferFrom and safeTransferFrom. This applies the appropriate modifiers to ALL transfers. No new issues created

KBT-02G - _msgSender() change to msg.sender at all instances. No new issues created

MAR-01G - startedAt now returns _updatedAt. startedAt is unused elsewhere so no new issues created.

KSP-01G - variable names of unused variables in onERC721Received have been removed. Since they are never used no new issues created.

code423n4 added a commit that referenced this issue Mar 20, 2023
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Mar 23, 2023
@c4-judge
Copy link

GalloDaSballo marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-Gas satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants