From 09350f322e3ec63164635daa19b24b685c318419 Mon Sep 17 00:00:00 2001 From: Nikola Begedin Date: Mon, 23 Oct 2017 13:35:08 +0200 Subject: [PATCH] Added Task archive tracking --- .../controllers/task_controller.ex | 11 ++++++++++ .../controllers/task_controller_test.exs | 21 +++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/lib/code_corps_web/controllers/task_controller.ex b/lib/code_corps_web/controllers/task_controller.ex index 769e0ef75..94d248bdb 100644 --- a/lib/code_corps_web/controllers/task_controller.ex +++ b/lib/code_corps_web/controllers/task_controller.ex @@ -47,6 +47,7 @@ defmodule CodeCorpsWeb.TaskController do current_user |> maybe_track_list_move(updated_task, task) current_user |> maybe_track_title_change(updated_task, task) current_user |> maybe_track_close(updated_task, task) + current_user |> maybe_track_archive(updated_task, task) conn |> render("show.json-api", data: updated_task) end @@ -113,4 +114,14 @@ defmodule CodeCorpsWeb.TaskController do user_id |> SegmentTracker.track("Closed Task", task) end defp maybe_track_close(%User{}, %Task{}, %Task{}), do: :nothing + + @spec maybe_track_archive(User.t, Task.t, Task.t) :: any + defp maybe_track_archive( + %User{id: user_id}, + %Task{archived: true} = task, + %Task{archived: false}) do + + user_id |> SegmentTracker.track("Archived Task", task) + end + defp maybe_track_archive(%User{}, %Task{}, %Task{}), do: :nothing end diff --git a/test/lib/code_corps_web/controllers/task_controller_test.exs b/test/lib/code_corps_web/controllers/task_controller_test.exs index 812969acd..14bd24d0c 100644 --- a/test/lib/code_corps_web/controllers/task_controller_test.exs +++ b/test/lib/code_corps_web/controllers/task_controller_test.exs @@ -264,6 +264,27 @@ defmodule CodeCorpsWeb.TaskControllerTest do refute_received {:track, ^user_id, "Closed Task", _} end + @tag :authenticated + test "tracks archiving task", %{conn: conn, current_user: current_user} do + task = insert(:task, user: current_user, archived: false) + attrs = @valid_attrs |> Map.put(:archived, true) + conn |> request_update(task, attrs) + + traits = Task |> Repo.get(task.id) |> SegmentTraitsBuilder.build + user_id = current_user.id + assert_received {:track, ^user_id, "Archived Task", ^traits} + end + + @tag :authenticated + test "does not track archiving task if no archive took place", %{conn: conn, current_user: current_user} do + task = insert(:task, user: current_user, archived: false) + attrs = @valid_attrs |> Map.delete(:archived) + conn |> request_update(task, attrs) + + user_id = current_user.id + refute_received {:track, ^user_id, "Archived Task", _} + end + @tag :authenticated test "renders 422 when data is invalid", %{conn: conn, current_user: current_user} do task = insert(:task, user: current_user)