diff --git a/lib/code_corps/policy/conversation_part.ex b/lib/code_corps/policy/conversation_part.ex index 7d7754165..8ca9161b7 100644 --- a/lib/code_corps/policy/conversation_part.ex +++ b/lib/code_corps/policy/conversation_part.ex @@ -24,6 +24,7 @@ defmodule CodeCorps.Policy.ConversationPart do queryable |> where(author_id: ^id) |> or_where([cp], cp.conversation_id in ^scoped_conversation_ids) + |> where(part_type: "comment") end def create?(%User{} = user, %{"conversation_id" => _} = params) do diff --git a/test/lib/code_corps/policy/conversation_part_test.exs b/test/lib/code_corps/policy/conversation_part_test.exs index 3b94b19fd..b18a32c3e 100644 --- a/test/lib/code_corps/policy/conversation_part_test.exs +++ b/test/lib/code_corps/policy/conversation_part_test.exs @@ -71,6 +71,8 @@ defmodule CodeCorps.Policy.ConversationPartTest do insert(:conversation_part, conversation: conversation_when_owner) part_in_some_other_conversation = insert(:conversation_part, conversation: some_other_conversation) + part_closed = + insert(:conversation_part, conversation: conversation_when_target, part_type: "closed") result_ids = ConversationPart @@ -84,6 +86,7 @@ defmodule CodeCorps.Policy.ConversationPartTest do assert part_in_administered_project.id in result_ids assert part_in_owned_project.id in result_ids refute part_in_some_other_conversation.id in result_ids + refute part_closed.id in result_ids end end