New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Slugged Routes Controller tests with helpers #441

Merged
merged 1 commit into from Nov 7, 2016

Conversation

Projects
None yet
4 participants
@amyschools
Contributor

amyschools commented Nov 4, 2016

What's in this PR?

Add api_case.ex helpers to controller test for slugged_routes.

References

Closes #439

Progress on: #413

@amyschools amyschools self-assigned this Nov 4, 2016

@joshsmith

After minor change this is good to go. 👍

assert data["attributes"]["user_id"] == slugged_route.user_id
path = "/#{slug}"
conn
|> get(path)

This comment has been minimized.

@joshsmith

joshsmith Nov 5, 2016

Contributor

Could we just pass the path in here directly?

@coveralls

This comment has been minimized.

coveralls commented Nov 7, 2016

Coverage Status

Coverage increased (+0.5%) to 94.337% when pulling 446d340 on 439-sluggedroutes-controller-test into 604f6df on develop.

@amyschools amyschools force-pushed the 439-sluggedroutes-controller-test branch from 446d340 to 57ec4ab Nov 7, 2016

@coveralls

This comment has been minimized.

coveralls commented Nov 7, 2016

Coverage Status

Changes Unknown when pulling 57ec4ab on 439-sluggedroutes-controller-test into * on develop*.

@amyschools amyschools force-pushed the 439-sluggedroutes-controller-test branch from 57ec4ab to ba60a2e Nov 7, 2016

@coveralls

This comment has been minimized.

coveralls commented Nov 7, 2016

Coverage Status

Coverage remained the same at 93.851% when pulling ba60a2e on 439-sluggedroutes-controller-test into 49f45b5 on develop.

@amyschools amyschools merged commit 7f418b2 into develop Nov 7, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 93.851%
Details

@amyschools amyschools deleted the 439-sluggedroutes-controller-test branch Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment