New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests with page objects #141

Closed
joshsmith opened this Issue May 31, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@joshsmith
Contributor

joshsmith commented May 31, 2016

http://ember-cli-page-object.js.org/docs/v1.4.x/components

Lets us do:

const page = PageObject.create({
  visit: visitable('/'),

  username: fillable('#username'),
  password: fillable('#password'),
  submit: clickable('button'),
  error: text('.errors')
});

test('my awesome test', function(assert) {
  page
    .visit()
    .username('admin')
    .password('invalid')
    .submit();

  andThen(() => {
    assert.equal(page.error, 'Invalid credentials');
  });
});
@green-arrow

This comment has been minimized.

Contributor

green-arrow commented Jun 28, 2016

@joshsmith - I have this started with the contributors acceptance test. Would you prefer one large pull request with a checklist of each test that needs migrated, or would you prefer a checklist here and multiple PRs referencing this issue?

@green-arrow

This comment has been minimized.

Contributor

green-arrow commented Jun 29, 2016

@joshsmith - so my apologies on this. I accidentally pushed some page object stuff to develop before you merged my other PR for the bower stuff. So the page object library and pattern is already in develop 😅

This is a checklist of tests that need to be migrated to the page object pattern:

  • Code theme
  • Contributors
  • Login
  • Logout
  • Navigation
  • Onboarding
  • Organization projects
  • Organization settings profile
  • Organization
  • Post comments
  • Post creation
  • Post editing
  • Profile
  • Project about
  • Project settings
  • Project
  • Projects
  • Settings profile
  • Signup
  • Slugged route
  • Team
@eablack

This comment has been minimized.

Contributor

eablack commented Aug 27, 2016

A few of these done in #381

@joshsmith

This comment has been minimized.

Contributor

joshsmith commented Oct 5, 2016

🎉 all done!

@joshsmith joshsmith closed this Oct 5, 2016

@joshsmith joshsmith removed ask hn labels Nov 20, 2016

@joshsmith joshsmith referenced this issue Nov 20, 2016

Closed

Rewrite integration tests with page objects #697

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment