Add skill ui to new task page #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
force-pushed
the
1046-skill-ui-to-new-task-page
branch
from
e8a3ff3 to
11f51e3
Compare
joshsmith
force-pushed
the
1046-skill-ui-to-new-task-page
branch
from
11f51e3 to
38872df
Compare
joshsmith
reviewed
Feb 15, 2017
| .then((task) => this.transitionToRoute('project.tasks.task', get(task, 'number'))) | ||
| .catch((payload) => this._handleTaskSaveError(payload)); | ||
| }, | ||
| deselectSkill(skill) { |
app/controllers/project/tasks/new.js
Outdated
| let unsavedTaskSkills = get(this, 'unsavedTaskSkills'); | ||
| let promises = unsavedTaskSkills.map((skill) => this._createTaskSkill(skill, task)); | ||
| return RSVP.all(promises).then(() => task); | ||
| }, |
Contributor
There was a problem hiding this comment.
Maybe this below _create... to keep alpha?
| }, | ||
|
|
||
| contains(skill) { | ||
| includes(skill) { |
Contributor
There was a problem hiding this comment.
Like renaming to includes here.
joshsmith
force-pushed
the
1046-skill-ui-to-new-task-page
branch
from
38872df to
c438bfa
Compare
joshsmith
force-pushed
the
1046-skill-ui-to-new-task-page
branch
from
c438bfa to
cf7fbed
Compare
joshsmith
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds basic skill assignment UI to the new task page. It works basically like the UI on the edit page, except the
task-skillrecords are actually created after the task is saved.Styling is not final, but can be dealt with in another PR.
The section listing the project skills for quick adding is also not there. It can be added with #1052
This should be reviewed and merged after reviewing and merging #1045
I also made a code change in the x-skill service layer. I renamed
.containsto.includes, reason being.containsis being deprecated on ember arrays. Since for the task new page, we use a plain ember array instead of a service, it would make sense for the interface to match.References
Progress on: #1046