Remove unnecessary check on MakeLocalVariableConstWhenItIsPossibleAna…

…lyzer Also add `Fact` to missing test Related to #774
code-cracker · Sep 6, 2016 · 352b6b3 · 352b6b3
1 parent 4dc4707
commit 352b6b3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs
@@ -36,8 +36,6 @@ private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
             var localDeclaration = (LocalDeclarationStatementSyntax)context.Node;
             var semanticModel = context.SemanticModel;
 
-            if (localDeclaration.GetType().IsPointer) return;
-
             if (!localDeclaration.IsConst
                 && IsDeclarationConstFriendly(localDeclaration, semanticModel)
                 && AreVariablesOnlyWrittenInsideDeclaration(localDeclaration, semanticModel) )

diff --git a/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs b/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs
@@ -52,6 +52,7 @@ public async Task IgnoresVariablesThatChangesValueOutsideDeclaration()
             await VerifyCSharpHasNoDiagnosticsAsync(test);
         }
 
+        [Fact]
         public async Task IgnoresPointerDeclarations()
         {
             var test = @"void* value = null;".WrapInCSharpMethod();