Loosen aws-sdk-core Requirement
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently targeting a specific minor version of the `aws-sdk-core` gem, despite not having any particular need for that level of specificity in this developer-environment-only gem. It also makes it more difficult to update the version of `aws-sdk-core` we target in our main repo. This PR loosens our requirement to let us pick up newer 3.x versions than the one we currently target. We could probably support older versions, too, if we have a need; happy to make that tweak if anyone would prefer.
cat5inthecradle
approved these changes
Nov 14, 2025
Hamms
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Nov 20, 2025
We also need to update our own `aws-google` gem to pick up code-dot-org/aws-google#13 Part of our ongoing investigation into the `SlowAWSResponse` errors we've been getting; we don't think it's likely that updating this gem will resolve those issues, but we would like to rule that out. Always nice to bring an old dependency up to date, anyway.
Hamms
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Dec 1, 2025
* Update `aws-sdk-core` Gem to Latest Version (3.239) We also need to update our own `aws-google` gem to pick up code-dot-org/aws-google#13 Part of our ongoing investigation into the `SlowAWSResponse` errors we've been getting; we don't think it's likely that updating this gem will resolve those issues, but we would like to rule that out. Always nice to bring an old dependency up to date, anyway. * target specific patch of aws-sdk-core to pick up login_credentials fix * make sure we pick up support for new integrity checking in aws-sdk-s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently targeting a specific minor version of the
aws-sdk-coregem, despite not having any particular need for that level of specificity in this developer-environment-only gem. It also makes it more difficult to update the version ofaws-sdk-corewe target in our main repo.This PR loosens our requirement to let us pick up newer 3.x versions than the one we currently target. We could probably support older versions, too, if we have a need; happy to make that tweak if anyone would prefer.
Testing Story
Verified that with this change in place, running
bundle update aws-sdk-corein our monorepo will successfully update us to3.237.0