From e913aaa328f93837ab61e4ac7b7f627e456b0d82 Mon Sep 17 00:00:00 2001
From: Ha Nguyen <ha@code.org>
Date: Tue, 19 May 2020 11:42:55 -0700
Subject: [PATCH] Tolerate failures in some extraction steps.

---
 dashboard/lib/contact_rollups_v2.rb | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/dashboard/lib/contact_rollups_v2.rb b/dashboard/lib/contact_rollups_v2.rb
index 8516a63b2b042..d9fcc96b0b012 100644
--- a/dashboard/lib/contact_rollups_v2.rb
+++ b/dashboard/lib/contact_rollups_v2.rb
@@ -2,31 +2,45 @@
 
 class ContactRollupsV2
   def initialize
-    @log_collector = LogCollector.new
+    @log_collector = LogCollector.new('Contact Rollups')
   end
 
   def collect_and_process_contacts
-    @log_collector.time!('Deletes intermediate content from previous runs') do
+    number_of_extractions = 2
+    successful_extraction_count = 0
+
+    @log_collector.time_and_raise!('Deletes intermediate content from previous runs') do
       truncate_or_delete_table ContactRollupsRaw
       truncate_or_delete_table ContactRollupsProcessed
     end
 
-    @log_collector.time!('Extracts data from dashboard email_preferences') do
+    @log_collector.time_and_continue('Extracts data from dashboard email_preferences') do
       ContactRollupsRaw.extract_email_preferences
+      successful_extraction_count += 1
     end
 
-    @log_collector.time!('Extracts parent emails from dashboard.users') do
+    @log_collector.time_and_continue('Extracts parent emails from dashboard.users') do
       ContactRollupsRaw.extract_parent_emails
+      successful_extraction_count += 1
     end
 
-    @log_collector.time!('Processes all extracted data') do
+    return unless successful_extraction_count
+    @log_collector.time_and_raise!('Processes all extracted data') do
       ContactRollupsProcessed.import_from_raw_table
     end
 
-    @log_collector.time!("Overwrites contact_rollups_final table") do
+    # Update the final table only if all the steps above have passed to avoid saving incomplete data.
+    if successful_extraction_count != number_of_extractions
+      @log_collector.info("Skips overwriting contact_rollups_final_table")
+      return
+    end
+
+    @log_collector.time_and_raise!("Overwrites contact_rollups_final table") do
       truncate_or_delete_table ContactRollupsFinal
       ContactRollupsFinal.insert_from_processed_table
     end
+  rescue StandardError => e
+    @log_collector.record_exception(e)
   end
 
   def sync_contacts_with_pardot