New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React from 15.2.1 to 15.3.0 #10076

Merged
merged 3 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@islemaster
Member

islemaster commented Aug 16, 2016

I've been getting peerDependency errors on a clean npm install from staging branch because of something down the dependency tree asking for 15.3, and this was getting in the way of my attempts to use react-virtualized-select. The upgrade from 15.2.1 to 15.3.0 is a fairly minor one, see the full changelog here.

I didn't find anything that had to change in response to this upgrade.

Testing

  • npm install from scratch now succeeds for me.
  • npm test passes all tests
  • npm start builds successfully
  • Fired up the application locally and went through level types in the AllTheThings script looking for new React warnings, found none.
  • Using CircleCI to run UI+eyes tests
@aoby

This comment has been minimized.

Show comment
Hide comment
@aoby

aoby Aug 16, 2016

Collaborator

LGTM

Collaborator

aoby commented Aug 16, 2016

LGTM

@islemaster

This comment has been minimized.

Show comment
Hide comment
@islemaster

islemaster Aug 16, 2016

Member

Update: Found one new warning. There's a spot in gamelab where we do some overly-clever validation, using React PropTypes in a non-React context. This now generates a warning and will be officially unsupported in React 16.

I've added a TODO. Since gamelab is still under active development, I can easily take care of this before React 16 happens.

Member

islemaster commented Aug 16, 2016

Update: Found one new warning. There's a spot in gamelab where we do some overly-clever validation, using React PropTypes in a non-React context. This now generates a warning and will be officially unsupported in React 16.

I've added a TODO. Since gamelab is still under active development, I can easily take care of this before React 16 happens.

Fix warning in gamelab
Removes use of React.PropTypes outside of React context, and does manual shape validation of animation data instead.  Tests updated to reflect corrected error messages.

This is necessary now because the React warning about this was causing an integration test to fail.  Not sure why I didn't catch this locally.

@islemaster islemaster merged commit 150869f into staging Aug 17, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

@islemaster islemaster deleted the react-15.3.0 branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment