Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-color from 2.2.2 to 2.2.5 #10273

Merged
merged 1 commit into from Aug 25, 2016
Merged

Upgrade react-color from 2.2.2 to 2.2.5 #10273

merged 1 commit into from Aug 25, 2016

Conversation

@islemaster
Copy link
Member

islemaster commented Aug 24, 2016

See: react-color changelog

There shouldn't be any user-facing change here. The major reason I'm excited about this upgrade is that it bumps reactcss from 0.4.3 to 1.0.6, which finally deduplicates React and Lodash within react-color and should reduce our overall bundle size, closing the book on a battle I've been waging since we updated to React 15 in #8178.

Bundle size measurements

Before and after the commit only changing the package version, via rm -rf build/package && npm install && npm run build:dist

bundle size @ 2.2.2 size @ 2.2.5 change
common.min.js 1711978 1671903 ~40k
netsim.min.js 554011 536561 ~17k

Total savings of about 57k - not huge, but it's something. I'm not totally sure why the netsim bundle changed; I re-ran the stats to make sure it's right. Maybe a dependency that used to be unique to netsim was added in react-color, moving it to the common bundle?

History of react-color updates

  • #7181 introduces react-color@^2.0.0
  • #8178 upgrades our project to React 15, starts using a fork react-color to be compatible.
  • #8274 updates forked react-color dependency, but mainline isn't ready for use due to duplicate dependency issue.
  • #10179 switches back to using mainline react-color@2.2.2 in an attempt to resolve npm@2 dependency issues.
  • #10186 manually pins a react-color dependency, fixing the dependency issue.
[Changelog](https://github.com/casesandberg/react-color/blob/master/CHANGELOG.md)

There shouldn't be any user-facing change here.  The major reason I'm excited about this upgrade is that it [bumps reactcss from 0.4.3 to 1.0.6](casesandberg/react-color#201), which finally deduplicates React and Lodash within react-color and should reduce our overall bundle size, closing the book on a battle I've been waging since we updated to React 15 in #8178.
@Bjvanminnen

This comment has been minimized.

Copy link
Contributor

Bjvanminnen commented Aug 24, 2016

sweet! lgtm

@islemaster islemaster merged commit 3111043 into staging Aug 25, 2016
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
@islemaster islemaster deleted the react-color-2.2.5 branch Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.