Maker: Alias accelerometer tap events #13061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent playground-io upgrade introduces `tap:single` and `tap:double` events for the accelerometer. This change allows students to refer to these events as `singleTap` and `doubleTap`, and adds those events to the `onBoardEvent` second parameter dropdown. I considered doing this aliasing in a wrapper around the `Accelerometer` controller, but there seems to be enough trouble with initialization and resets that this broke some behaviors. I think it's cleaner for now to just alias at the `onBoardEvent` level and revisit this if/when we manage to simplify the run/reset process.
Hamms
approved these changes
Feb 6, 2017
| // https://docs.google.com/document/d/1VuDefx4wijBkyiap-36qpfCAoNEzu5B7yLldhhhuv7U/edit#bookmark=id.daat8jt8eda8 | ||
| if (BOARD_EVENT_ALIASES[event]) { | ||
| event = BOARD_EVENT_ALIASES[event]; | ||
| } |
There was a problem hiding this comment.
Love it when previously-established structure makes it possible for additions like this to be clean and simple!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent playground-io upgrade introduces
tap:singleandtap:doubleevents for the accelerometer. This change allows students to refer to these events assingleTapanddoubleTap, and adds those events to theonBoardEventsecond parameter dropdown. (spec)I considered doing this aliasing in a wrapper around the
Accelerometercontroller, but there seems to be enough trouble with initialization and resets that this broke some behaviors. I think it's cleaner for now to just alias at theonBoardEventlevel and revisit this if/when we manage to simplify the run/reset process.